search

kswedberg / jquery-expander

Expand and Collapse HTML content
https://kswedberg.github.io/jquery-expander/
Other
459 stars 168 forks source link

Change define usage #111

Closed samlii closed 8 years ago

samlii commented 8 years ago

Define Change: Mirror usage on https://github.com/umdjs/umd/blob/master/jqueryPluginCommonjs.js The define portion wasn't working for me, but I do not have in depth knowledge of AMD.

Option added: Added an option to not normalize the white space when creating the sub components. This is to allow for when you have a whitespace setting of pre, and want the data inside to retain its formatting.

kswedberg commented 8 years ago

@samlii Thanks for the UMD fix and for the extra option. I think that will come in handy for others, too. I'm going to merge them in as two separate commits, so keep an eye out for them. Also, I really appreciate your writing tests for the new option. Thanks!

kswedberg commented 8 years ago

Closed by eaaa5434b1a8693400cddd0e0165aa6a0c56f459 and cc73c5e988cc62a0ecf9c778df03f0a08475ed00

Thanks, @samlii !