search

kswedberg / jquery-smooth-scroll

Automatically make same-page links scroll smoothly
MIT License
1.97k stars 427 forks source link

jQuery 3.X deprecation warning #97

Closed chrisdl closed 8 years ago

chrisdl commented 8 years ago

Hey

Great library. jQuery migrate (https://code.jquery.com/jquery-migrate-3.0.0.js) raises a deprecation warning about the swing animation.

JQMIGRATE: easing function "jQuery.easing.swing" should use only first argument

It is only deprecated, not removed but it will probably stop working for next major version of jQuery.

kswedberg commented 8 years ago

Interesting! I'm seeing deprecation warnings for delegate, undelegate and bind, but not for jQuery.easing.swing. Can you point me to a page that is experiencing the issue?

chrisdl commented 8 years ago

Actually I can't! Not sure why I can't reproduce on jsfiddle I had no issues reproducing on my local environment. and the version of the lib should be the same.

https://jsfiddle.net/2227kazm/10/

The behavior in the fiddle mimics my local

on ready
    on click
        scroll to target

It was only on the smoothscroll actually being called that jquery migrate logged out to jsconsole that there was an issue. I'll try to think what the difference between the fiddle and my local could be, but as of right now im stumped for reproducing.

kswedberg commented 8 years ago

Strange! Thanks for looking into it. And if you do track down the source of the problem, please let me know.

chrisdl commented 8 years ago

Np. So want me to close down the issue for now, and you can simply file it away in your gray matter that something might be funky in the future with how you are calling jquery animations?

kswedberg commented 8 years ago

Sure, that would be great. Thanks again.