search

ksylvest / omniai-openai

An implementation of the OmniAI interface for OpenAI.
https://omniai-openai.ksylvest.com
MIT License
3 stars 2 forks source link

Adding OmniAI::LocalAI and OmniAI::Ollama #33

Closed MadBomber closed 1 month ago

MadBomber commented 2 months ago

I'm not sure whether this is a good place to add these as part of OmniAI::OpenAI or whether they should be in their own gem.

ksylvest commented 2 months ago

I think it should be split into a separate gem (e.g.gomniai-localai + omniai-ollama) since you are grabbing a new namespace (e.g. LocalAI).

MadBomber commented 2 months ago

I agree with you @ksylvest so I changed the PR to a draft so that we might continue to discuss the new namespace if you are interested. If not you may just close the PR.

I have a repo of the new gem at https://github.com/MadBomber/omniai-ollama

One of the things that I am trying within my local working directory is to adapt the entire OmniAI::OpenAI test suite to the new namespace. While I am getting many errors and failures due primarily to the mocked requests not matching even after a global search and replace of "api.openai.com" with "localhost:11434", the effort did point out many of the classes which I failed to alias in this PR.

MadBomber commented 1 month ago

@ksylvest I'm closing this PR as OBE.