search

ksz-ksz / rxjs-insights

See through the observables.
MIT License
358 stars 13 forks source link

update isPromise guard #14

Closed IvanGrimes closed 11 months ago

IvanGrimes commented 12 months ago

The StacktraceLocator class has a method getOriginalLocation that may return an undefined. The locate method uses a value returned by getOriginalLocation and passes it through a guard isPromise. However, the isPromise guard doesn't have a check if the value is not undefined, even though the getOriginalLocation method may return an undefined. Therefore, if getOriginalLocation returns an undefined location, we end up getting an error like "Cannot use 'in' operator to search for 'then' in undefined".

ksz-ksz commented 11 months ago

Thank for the contribution. I'll take a look today or tomorrow.

IvanGrimes commented 11 months ago

Thank for the contribution. I'll take a look today or tomorrow.

Am looking forward to :)

ksz-ksz commented 11 months ago

Sorry for the delay. Your changes should be included in 0.5.1. Thanks for your patience and a great contribution!

IvanGrimes commented 11 months ago

Glad to hear that; hopefully it'll fix the problem :)