search

kszucs / pandahouse

Pandas interface for Clickhouse database
MIT License
229 stars 70 forks source link

Support basic auth #12

Closed kung-foo closed 6 years ago

kung-foo commented 6 years ago

Authentication credentials should not be passed via query string. This PR moves them to the Authorization HTTP header.

kszucs commented 6 years ago

Hey @kung-foo @haakonvt !

Thanks for your PR and sorry for the late response! I was pretty busy lately. Are You still using clickhouse with pandas within Intelecy? I know a couple of ways to improve the integration (including its efficiency) if You're interested.

haakonvt commented 6 years ago

Definitely interested in efficiency @kszucs!