kt3k / coveralls-gradle-plugin

👨‍🔧 gradle plugin for coveralls
https://plugins.gradle.org/plugin/com.github.kt3k.coveralls
MIT License
253 stars 54 forks source link

Fixes NPE when coverage.xml has multiple <source> element #1

Closed bric3 closed 10 years ago

bric3 commented 10 years ago

Coverage report can have multiple source folders

    <sources>
        <source>src/main/java</source>
        <source>src/main/groovy</source>
    </sources>

Aside of that Gradle's Cobertura plugin can generate an additional wrong source folder.

So this PR

Also I'd like to thank Adrien Lecharpentier (@alecharp) who helped me to coin this bug

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 899ba2a59d853a955c9aae12bd19afce762af166 on bric3:fixes_multiple_source_element into 5bd222c6972513b1927a41174aa57814cf0e3580 on kt3k:master.

kt3k commented 10 years ago

Thank you for the suggestion!

This seems the right treatment of <source> entries.

Thanks for improvement :smile:

bric3 commented 10 years ago

You're welcome :smile_cat: Thx for crafting the first usable code

kt3k commented 10 years ago

deployed v0.1.5, including this fix.

bric3 commented 10 years ago

Cool thanks.

I've put your plugin at use there : https://github.com/mockito/mockito By the way, it would be great to see this plugin on mavenCentral()

Cheers.

kt3k commented 10 years ago

@bric3

I'm very impressed with seeing mockito using my plugin! :smile:

By they way, it would be great to see this plugin on mavenCentral()

I'll try.

bric3 commented 10 years ago

You're welcome :smile_cat:

Thanks for the initial implementation.

Cheers

kt3k commented 10 years ago

Hi, @bric3

I deployed v0.1.6 of the plugin to Maven Central. http://search.maven.org/#artifactdetails%7Corg.kt3k.gradle.plugin%7Ccoveralls-gradle-plugin%7C0.1.6%7Cjar

bric3 commented 10 years ago

That's great, thanks a lot :)