search

kt3k / coveralls-gradle-plugin

👨‍🔧 gradle plugin for coveralls
https://plugins.gradle.org/plugin/com.github.kt3k.coveralls
MIT License
253 stars 54 forks source link

JacocoSourceReportFactory: fix filename passed to SourceReport #11

Closed dhalperi closed 10 years ago

dhalperi commented 10 years ago

We need to use the path relative to the current working directory ('.'), not only the canonical Java filename of /class.java.

This fixes kt3k/coveralls-gradle-plugin #10.

Note that the approach to come up with the true relative path seems a little circuitous. But I didn't see an obviously better way to handle it..

kt3k commented 10 years ago

Hi!

Thank you for this fix!

I was not even aware of this issue. (I think this may be because of the previous migration of the site in the last weekend.)

Note that the approach to come up with the true relative path seems a little circuitous. But I didn't see an obviously better way to handle it..

OK. I think this is no problem for now.

Thank you!