search

kt3k / coveralls-gradle-plugin

👨‍🔧 gradle plugin for coveralls
https://plugins.gradle.org/plugin/com.github.kt3k.coveralls
MIT License
253 stars 54 forks source link

Added Android Plugin support. Pulls in the Main Source. #17

Closed chrisjenx closed 10 years ago

chrisjenx commented 10 years ago

This uses the Main sourceSet of the Android plugins (Android/Library) they both inherit from the BasePlugin now.

This shouldn't be nessary, but setting https://github.com/kt3k/coveralls-gradle-plugin/blob/master/src/main/groovy/org/kt3k/gradle/plugin/CoverallsPluginExtension.groovy#L26 has no effect on the project.extentions.coveralls.sourceSets property.

If you fix that then, this becomes slightly obsolete.

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-0.76%) when pulling e2a1e22f4af81a28f261a3d1c1d1828842bd58ae on justyoyo:fix/android-plugin into 9253a4eb88add2a7dc5041905b1a97da92a63658 on kt3k:master.

kt3k commented 10 years ago

Hi,

Thanks for your contribution!

Sorry for some inconvenience. project.extentions.coveralls.sourceSets is for now only in master branch and has not been released yet.

And even if we released that feature, this change would be useful for android projects because it enables users to upload android app coverage without configuration. (In my opinion, the capability without any configuration is important for this kind of tool.) So I'll merge this.

Thanks,

kt3k commented 10 years ago

Deployed as v0.5.0.

Thanks,

chrisjenx commented 10 years ago

@kt3k no worries.