search

kt3k / coveralls-gradle-plugin

👨‍🔧 gradle plugin for coveralls
https://plugins.gradle.org/plugin/com.github.kt3k.coveralls
MIT License
253 stars 54 forks source link

Add Jacoco support #2

Closed ihiroky closed 10 years ago

ihiroky commented 10 years ago

This update includes JaCoCo support. Add interface to parse coverage report, and prepare implementations for Covertura and JaCoCo.

The algorithm to check coverage by JaCoCo is the same as coveralls-maven-plugin.

kt3k commented 10 years ago

Thanks for the PR!

I will review in a few days.

By the way, the travis state is not green. Can you check it? (I guess probably you forgot to commit the deletion of SourceReportFactoryTest.)

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-4.17%) when pulling 35e31e72871cc79e438c95beec543f5a08ddc096 on ihiroky:jacoco-prototype into 98e283c07cbf3ba8c3e157c9a1b667ee0d6df0a2 on kt3k:master.

ihiroky commented 10 years ago

Sorry, as you indicated. The code in SourceReportFactoryTest is moved to CoberturaSourceReportFactoryTest.

kt3k commented 10 years ago

I tested on my another repository and I confirmed that this handles both jacoco and cobertura report files. ( https://coveralls.io/builds/363247 https://coveralls.io/builds/363253 )

And codes and tests seem ok.

Thanks for nice enhancement! :)

kt3k commented 10 years ago

I deployed v0.2.1 to Maven Central, including this feature.

thanks! :)

ihiroky commented 10 years ago

Your welcome. Thank you for your creating the wonderful plugin, too.