search

kt3k / coveralls-gradle-plugin

👨‍🔧 gradle plugin for coveralls
https://plugins.gradle.org/plugin/com.github.kt3k.coveralls
MIT License
253 stars 54 forks source link

Adding Jenkins CI support and updating README #33

Closed dallasgutauckis closed 9 years ago

dallasgutauckis commented 9 years ago
coveralls commented 9 years ago

Coverage Status

Coverage decreased (-1.13%) to 83.77% when pulling 7c480bc6f692cd5c5fc950cc46088c3e6b4c0920 on seatgeek:pr-jenkins into 0f4e0bb23f98b29903da3c3cbcd05e98648d57c4 on kt3k:master.

kt3k commented 9 years ago

Really thanks for the enhancement and documentation!

I'll release it soon.

dallasgutauckis commented 9 years ago

My pleasure.

kt3k commented 9 years ago

Released this version as v2.2.0.

http://search.maven.org/#artifactdetails%7Corg.kt3k.gradle.plugin%7Ccoveralls-gradle-plugin%7C2.2.0%7Cjar https://bintray.com/kt3k/gradle-plugins/coveralls-gradle-plugin/2.2.0/view

Thanks,

dallasgutauckis commented 9 years ago

Hey @kt3k I've noticed that this is not showing the right pull number in coveralls.io; I've tried both the direct link and the number. Any idea what the value is supposed to be for the servicePullRequest?

kt3k commented 9 years ago

https://coveralls.zendesk.com/hc/en-us/articles/201770395-Do-you-support-Circle-CI-pull-request-comments- This post says it should be CircleCI's CI_PULL_REQUEST env var. I'm personally not using CircleCI, then I can't give an example at the moment, but I'll try to check it later.

kt3k commented 9 years ago

https://github.com/circleci/frontend/blob/master/resources/assets/docs/environment-variables.md#build-details According to this doc, it should be the url of the pull request. Hmm strange...

dallasgutauckis commented 9 years ago

The original implementation uses the URL, but coveralls shows "Pull #0" and doesn't link to the correct PR when clicked either. This might need some input from the coveralls team.