Closed thejohnfreeman closed 7 years ago
After pushing this latest fix, the build passed with oraclejdk8
and failed with oraclejdk7
. I believe that failure is spurious, caused by some transient internet connectivity problem. I believe that if you restart the build, which I cannot do, then it will pass.
The fall in coverage is due to following the pattern for the JacocoSourceReportFactoryTest where only the static method is tested, but not the instance method that finds the source directories.
Thanks for the constribution!
All looks good to me. I agree that the test failure in travis (oraclejdk7) is irrelevant of this PR. (I found similar issue.)
I'll publish this version in a few days.
Published as v2.8.0!
Closes #70