search

kt3k / coveralls-gradle-plugin

👨‍🔧 gradle plugin for coveralls
https://plugins.gradle.org/plugin/com.github.kt3k.coveralls
MIT License
253 stars 54 forks source link

Replace ghprbPullLink with ghprbPullId in ServiceInfoFactory.groovy #79

Closed jettbow closed 7 years ago

jettbow commented 7 years ago

serviceInfo.servicePullRequest should be assigned as Id of a PR.

kt3k commented 7 years ago

Thanks for the contribution! The change makes sense to me. Can you update the test case for this class as well?

(see: https://travis-ci.org/kt3k/coveralls-gradle-plugin/jobs/288501355 )

jettbow commented 7 years ago

Sure! Updated.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 95.077% when pulling 02d996c403d3d1eb8aaae9b29e15c053772acef8 on jettbow:master into 992d48cac94b9cc0d07945ea02c4c706b1f3e468 on kt3k:master.

jettbow commented 7 years ago

@kt3k Fixed.

kt3k commented 7 years ago

Released as v2.8.2 https://plugins.gradle.org/plugin/com.github.kt3k.coveralls http://repo1.maven.org/maven2/org/kt3k/gradle/plugin/coveralls-gradle-plugin/2.8.2/