Refactor of the Firebase library

llbbl commented 9 years ago

Hey Tamas - Decided to work on your firebase library today. Here is a summary of the changes.

Moved files around to follow the common conventions
Added a Namespace
Added Docblocks
Updated gitignore a bit to ignore composer stuff and composer.json so the FirebaseLib will be autoloaded
Added an Autoloader and phpunit xml files
Renamed main class name to look/work better with the namespace
Added an example to the readme

ktamas77 commented 9 years ago

Thank you for your great contribution!

llbbl commented 9 years ago

You are welcome! Happy to help. Thanks for accepting it. @iansltx mentioned to me over the weekend that we should consider bumping it to the version number to a major one since it was a fairly sizable refactor and renaming of the class will break things for people. Good idea to follow Semantic Versioning I suppose. Going from 1.x to 2.x without any minor releases is kind of silly, but maybe we can clean up or add a few more things before tagging? Thoughts?

ktamas77 commented 9 years ago

I agree - Version is now officially 2.0.0. Thank you for your suggestion!

On Mon, Mar 2, 2015 at 6:41 AM, Logan Lindquist notifications@github.com wrote:

You are welcome! Happy to help. Thanks for accepting it. @iansltx https://github.com/iansltx mentioned to me over the weekend that we should consider bumping it to the version number to a major one since it was a fairly sizable refactor and renaming of the class will break things for people. Good idea to follow Semantic Versioning I suppose. Going from 1.x to 2.x without any minor releases is kind of silly, but maybe we can clean up or add a few more things before tagging? Thoughts?

— Reply to this email directly or view it on GitHub https://github.com/ktamas77/firebase-php/pull/21#issuecomment-76722518.

Tamas Kalman

Phone: +14153359822 E-mail: ktamas77@gmail.com Linkedin: http://www.linkedin.com/in/ktamas

ktamas77 / firebase-php

Refactor of the Firebase library #21