search

ktamas77 / firebase-php

Firebase PHP Client
791 stars 215 forks source link

New interface for advanced phpunit testing and phpunit testing on the firebaseLib #7

Closed brianpilati closed 10 years ago

brianpilati commented 10 years ago

Tamas,

Thanks for your work on the firebase-php library. You really saved me on a project I am working on.

In my project, I wanted to use phpunit to test without any latency. As such, I wrote an interface to be consumed by both the firebaseLib and a new firebaseStub that I created for phpunit testing.

In the course, of adding the firebaseStub, I noticed that your unit tests did not actually verify the results from firebase. So, I converted your tests into phpunit tests. To make all of this happen, I need to add a few directories: lib and tests.

I also added an additional validation for the baseURI during the class initialization.

In addition, I updated the README file to include all of the changes with explanations of how to use the Stub for testing.

Let me know, how I can help merge this code.

brianpilati commented 10 years ago

I forgot to mention that I did NOT make any alterations to the Build Status (it will need to be converted to run phpunit) or Scrutinizer Quality Score. You will need to handle both of these changes.

ktamas77 commented 10 years ago

Thank you for your detailed work on PHP Unit tests!

brianpilati commented 10 years ago

No problem. Thanks for the great library. Let me know if I can help in the future.

ktamas77 commented 10 years ago

The CI badges are updated automatically on each merge - and it's passing beautifully. Thank you for your contribution again!