search

ktbartholomew / saml-20-single-sign-on

Wordpress plugin that makes a Wordpress site act as a SAML service provider
GNU General Public License v2.0
37 stars 22 forks source link

Upgrading from 0.9.2 to 0.9.3 deletes admin group mapping #12

Closed ktbartholomew closed 8 years ago

ktbartholomew commented 8 years ago

@phille97 I just spoke with a user who had this issue and (luckily) had SSO bypass enabled to fix it.

Prior to 0.9.3, the name of the administrator role was admin. Since 0.9.3, however, the name of the role is administratror. This mismatch is leaving users who upgrade to 0.9.3 or later with no admin users.

We should add a bit of upgrade logic (similar to https://github.com/ktbartholomew/saml-20-single-sign-on/blob/master/src/lib/classes/saml_settings.php#L382) to copy the value from the older admin role to administrator for a smooth upgrade transition.

stephen-kainos commented 8 years ago

@ktbartholomew i've been affected by this as well. All admins lost access. What's the best way to fix this?

ktbartholomew commented 8 years ago

@stephen-kainos short of cutting/shipping another version with the upgrade logic described above, you could uninstall and reinstall the plugin. When you set up the group mappings again, they'll get assigned to the right places. If you do this, you may want to save the certificate/key generated by the plugin to avoid having to reconfigure the certificate with your identity provider.

phille97 commented 8 years ago

Hi @ktbartholomew ! I created a PR that should fix this.

Sorry that I couldn't get back to you until now, i've been kinda busy lately

ktbartholomew commented 8 years ago

Fixed w/ #13