search

ktbartholomew / saml-20-single-sign-on

Wordpress plugin that makes a Wordpress site act as a SAML service provider
GNU General Public License v2.0
37 stars 22 forks source link

Calling assert() with a string argument is deprecated in PHP 7.2 #27

Open kevaschmim opened 6 years ago

kevaschmim commented 6 years ago

We have been using this plugin for some time now and upgraded our Wordpress sites to the latest version, and also upgraded PHP in these instances to the latest version, but started getting this error:

Deprecated: assert(): Calling assert() with a string argument is deprecated in /var/www/html/wp-content/plugins/saml/saml/lib/SimpleSAML/Auth/Simple.php on line 25

The error also comes up in many more files when we try to log in, this is just the one that makes it to the front page.

Are there any plans to update this plugin to handle this?

Promaethius commented 5 years ago

@kevaschmim note that this plugin uses an upstream version of SimpleSAMLPHP from https://github.com/simplesamlphp/simplesamlphp https://simplesamlphp.org/archive indicates there are no major API changes over the last two years so you should be able to simply overwrite the saml directory with the root of simplesamlphp. https://simplesamlphp.org/docs/1.16/simplesamlphp-changelog#section_3