Closed bmanth60 closed 8 years ago
This was tested using the singlesite and multisite containers, and is functional for both.
@bmanth60 good idea! I'll dig into the changes in a little bit.
@ktbartholomew thanks! sounds good!
@ktbartholomew Thanks for the feedback!
@ktbartholomew I have updated the code, thanks!
@ktbartholomew Just following up on this PR. Are there any further feedback that I should update in this regards? Thanks!
@bmanth60 sorry, I wasn't sure if you were done making your changes. In light of the minor upgrade fiasco caused by the last version bump, I'll need to spend a little time testing how these changes behave when users transition from previous versions to this one.
Heh, looks like I missed your very obvious indication that you were done with your changes: https://github.com/ktbartholomew/saml-20-single-sign-on/pull/5#issuecomment-210374949 whoops!
Hi,
We are using a docker instance of wordpress that is using an external database, and when we do updates we are recreating the container which causes the saml plugin to lose its configurations. This PR moves the config into database so the containers can be restarted.
-Brian