introduces `raise_on_parsing_error` parameter to `send_command`

ktbyers / netmiko

Multi-vendor library to simplify Paramiko SSH connections to network devices

MIT License

3.63k stars 1.31k forks source link

introduces `raise_on_parsing_error` parameter to `send_command` #3406

Closed Kircheneer closed 2 months ago

Kircheneer commented 8 months ago

Allow exceptions from structured data parsers to bubble up to the callers of send_command and send_command_timing. This is useful for example in conjunction with nornir_netmiko, which currently can't fail tasks based on failed parsing, leading to successful tasks with garbage data.

Kircheneer commented 8 months ago

As discussed on Slack I have renamed the parameter and added an initial set of tests.

Kircheneer commented 8 months ago

Please approve CI workflow whenever possible. Thanks!

tom0010 commented 3 months ago

Looks to fix https://github.com/ktbyers/netmiko/issues/3479

ktbyers commented 2 months ago

Superseded by https://github.com/ktbyers/netmiko/pull/3494