inaba-vdom-0
commented
2 months ago I have fixed the Telnet bug by ignoring option negotiation to maintain the session.
class NecIxTelnet(NecIxBase):
"""NecIx Telnet driver."""
def ignore_option_negotiation(self, sock, cmd, opt):
pass
def telnet_login(
self,
pri_prompt_terminator: str = r"#\s*$",
alt_prompt_terminator: str = r">\s*$",
username_pattern: str = r"login",
pwd_pattern: str = r"assword",
delay_factor: float = 1.0,
max_loops: int = 20,
) -> str:
self.remote_conn.set_option_negotiation_callback(self.ignore_option_negotiation)
return super().telnet_login(
pri_prompt_terminator = pri_prompt_terminator,
alt_prompt_terminator = alt_prompt_terminator,
username_pattern = username_pattern,
pwd_pattern = pwd_pattern,
delay_factor = delay_factor,
max_loops = max_loops
)Router debug log
DEBUG:netmiko:read_channel: login:
DEBUG:netmiko:write_channel: b'test-ix\r'
DEBUG:netmiko:read_channel: test-ix
Password:
DEBUG:netmiko:write_channel: b'********\r'
DEBUG:netmiko:read_channel:
NEC Portable Internetwork Core Operating System Software
Copyright Notices:
Copyright (c) NEC Corporation 2001-2022. All rights reserved.
Copyright (c) 1985-1998 OpenROUTE Networks, Inc.
Copyright (c) 1984-1987, 1989 J. Noel Chiappa.
Router#
DEBUG:netmiko:write_channel: b'\r'
DEBUG:netmiko:read_channel:
Router#
DEBUG:netmiko:Clear buffer detects data in the channel
DEBUG:netmiko:read_channel:
DEBUG:netmiko:write_channel: b'\r'
DEBUG:netmiko:read_channel:
DEBUG:netmiko:read_channel:
DEBUG:netmiko:read_channel:
Router#
DEBUG:netmiko:Pattern found: (\#)
Router#
DEBUG:netmiko:read_channel:
DEBUG:netmiko:Clear buffer detects data in the channel
DEBUG:netmiko:read_channel:
DEBUG:netmiko:[find_prompt()]: prompt is Router#I will conduct tests over the weekend and, if there are no issues, will submit the pull request again. Thank you for your continued support.
ktbyers
I added support for the NEC Univerge IX Router series. https://jpn.nec.com/univerge/ix/index.html
Test configuration:
test_devices.yml
commands.yml
responses.yml
nec_ix_commands.txt
I will send the test results, but there are some issues.
test_result.log
I also conducted tests for autodetection.
logging.basicConfig(filename="netmiko_test-code.log", level=logging.DEBUG) logger = logging.getLogger("netmiko")
remote_device = { 'ip': '192.168.1.30', 'username': 'test-ix', 'password': 'testnecix123', 'device_type': 'autodetect', 'global_delay_factor': 3, 'session_log' : 'test-code.log', 'fast_cli' : False }
guesser = SSHDetect(**remote_device) best_match = guesser.autodetect() print(best_match) print(guesser.potential_matches)
remote_device['device_type'] = best_match connection = ConnectHandler(**remote_device)
result = connection.send_command(command_string='show version')
connection.disconnect()
test-code.log
Issues:
exit_config_mode
test_exit_config_mode in test_netmiko_config.py, an error occurs because check_config_mode returns True after exit_config_mode. Although the configure command is used to return to the top menu of the configure mode from the interface configure mode, the prompt usually remains the same. Using the exit command will exit the configure mode, limiting the available show commands. Therefore, it is necessary to use the configure command as much as possible.
example command logging
Telnet driver
There is a bug in the Telnet driver. When performing telnet access, login fails and returns a "telnet connection closed" error. terminal log
When debugging with debug logs and breakpoints, it was found that the base_connection forcibly closes the session when executing output = self.read_channel(). Router debug logging reveals that the TELS.003: Disconnected client log is outputted at the timing of output = self.read_channel().
base_connection.py
netmiko_debug.log
Router debug log
These issues can be submitted as separate issues rather than as part of a pull request.
Thank you!