search

ktbyers / netmiko

Multi-vendor library to simplify Paramiko SSH connections to network devices
MIT License
3.56k stars 1.3k forks source link

Aruba CX naming update is wrong #3443

Closed pietos closed 3 months ago

pietos commented 3 months ago

Description of Issue/Question

We submitted the new Aruba vendor as how it's called in the market & community Aruba AOS-CX I see now that in a recent commit you changed it to Aruba-CX, which is incorrect. Therefor I would like to request to undo the naming change back to aruba_aoscx

This will also conflict with the exiting NTC template: https://github.com/networktocode/ntc-templates/tree/master/ntc_templates/templates

Aruba tech: https://www.arubanetworks.com/techdocs/AOS-CX/help_portal/Content/home.htm

ktbyers commented 3 months ago

Fix is to just add a second entry and map "aruba_aoscx" to the existing driver. Obviously, I was not aware that ntc-templates had an existing name for this platform.

"aruba_aoscx": ArubaCxSSH,
Trailingslashes commented 3 months ago

This is was worked for me in my environment, but I don't know if renaming the platform is the best path forward - https://github.com/Trailingslashes/netmiko/commit/927e02b06a0b825be47e1402e2f42fac3d83152c

ktbyers commented 3 months ago

@Trailingslashes Not sure I follow you? Was there a question or concern here?

Trailingslashes commented 3 months ago

@ktbyers, no concern, I just wasn't sure if I should submit a PR to update the platform name.

ktbyers commented 3 months ago

@Trailingslashes Either way is fine (you can submit it or I can submit it). I will try to do it this week otherwise.

ktbyers commented 3 months ago

Fixed here:

https://github.com/ktbyers/netmiko/pull/3448

ktbyers commented 2 months ago

@pietos @Trailingslashes FYI, Netmiko 4.4.0 was released today that includes this fix and Aruba CX support.