plucena24
commented
9 years ago The following components are the main changes needed for the netmiko library to be compatible with Python 2 and Python 3.
- Using the print() function instead of the print statement
if debug:
print("In set_base_prompt")- Changing relative import statements to absolute
from netmiko.cisco.cisco_ios_ssh import CiscoIosSSHor
from . cisco_ios_ssh import CiscoIosSSHinstead of
from cisco_ios_ssh import CiscoIosSSH- Using the unicode 'sandwich' pattern where input bytes (output from SSH sessions, files read from disk, etc) are decoded to unicode as soon as possible. Unicode strings are carried throughout the program, and if need to output, encoded back to bytes right before output.
- All string manipulation code will not be affected as long as all input bytes are decoded to unicode right away.
- utf-8 encoding should be used
output = self.remote_conn.recv(MAX_BUFFER).decode('utf-8')- For opening files, the
iomodule'sopen()method should be used, as it has anencodingargument just like the builtinopenfunction in Python 3. This will take care of any input bytes read from disk entering the program.
import io
with io.open(config_file, encoding='utf-8') as cfg_file:
return self.send_config_set(cfg_file, **kwargs)- ANSI ESC sequences currently using
chr(27)will continue working under Python3 without modification, as ASCII values map directly to the same values in Unicode code points. - Modify exception handling code using the following format (only one occurrence found thus far, base_connection.py line 471). This is not valid Python3 syntax:
except IOError as (errno, strerr):
print("I/O Error {0}: {1}".format(errno, strerr))- Instead, the following format should be used:
except IOError as e:
errno, strerr = e.args
print("I/O Error {0}: {1}".format(errno, strerr))These are the main factors that would need to change in order to be compatible with Python3.
daenney
ktbyers
Placeholder to figure out the issues involved in doing htis.