search

ktdreyer / errata-tool-ansible

Ansible modules to manage Red Hat Errata Tool resources
GNU General Public License v3.0
4 stars 14 forks source link

ima_sig_key fixes #310

Closed ktdreyer closed 1 year ago

ktdreyer commented 1 year ago

A couple of fixes for the CI, and a followup to https://github.com/ktdreyer/errata-tool-ansible/pull/309:

  1. Fix the integration tests to handle the addition of prerelease-{{advisory}} to DEFAULT_TAG_TEMPLATES from CWFCONF-5454.

  2. Remove type='str' from the module's argument_spec, since this is Ansible's default behavior already.

  3. When creating a new Product Version without ima_sig_key_name, don't send any ima_sig_key_name value to the server. (This fixes a crash in the integration tests. For some reason the server responded with a HTTP 500 error.)

  4. Add new integration tests for setting ima_sig_key_name on new and existing Product Versions.

ktdreyer commented 1 year ago

Since this fixes a crash in errata_tool_product_versions, I'm going to merge this now.

hluk commented 1 year ago

Thanks for the fixes!

3. When creating a new Product Version without ima_sig_key_name, don't send any ima_sig_key_name value to the server. (This fixes a crash in the integration tests. For some reason the server responded with a HTTP 500 error.)

Maybe a bug in ET? Sounds like it is not possible to unset the key (update with null value).

ktdreyer commented 1 year ago

Maybe a bug in ET?

Yeah, I did not investigate further, but something was odd there.

I should have asked you to push the branch to the main repo. Next time I'll remember that. Then the integration tests will run on the changes.