ktdreyer / helga-bugzilla

bugzilla ticket integration for Helga IRC bot
0 stars 0 forks source link

gracefully handle txbugzilla exceptions #16

Closed ktdreyer closed 6 years ago

ktdreyer commented 7 years ago

We're barfing on txbugzilla's BugzillaNotAuthorizedException error here:

<user> BZ 445891
< helga>: You are not authorized to access bug #445891. Most likely the bug has been restricted for internal development processes and we cannot grant access. If you are a Red Hat customer with an active subscription, please visit the Red Hat Customer Portal for assistance with your issue If you are a Fedora Project user and require assistance, please consider
<helga>: using one of the mailing lists we host for the Fedora Project.
< kraken>: /opt/helga/lib/python2.7/site-packages/txbugzilla/__init__.py:208:_parse_errback

We should gracefully handle this exception in helga_bugzilla.send_err(). In helga-redmine, we handle this by still printing the URL to the ticket, along with [could not read subject (reason)]. We could do the same here, like: [could not read subject (not authorized)]

Additionally, we hit a similar _parse_errback traceback with unknown bugs:

< ktdreyer>: bz 123456789
< kraken>: Bug #123456789 does not exist.
< kraken>: /opt/helga/lib/python2.7/site-packages/txbugzilla/__init__.py:206:_parse_errback

In this case it's ok to just avoid the traceback and print the error message directly. Bug #XXX does not exist. is simple enough.

ktdreyer commented 6 years ago

Resolved in https://github.com/ktdreyer/helga-bugzilla/pull/19