ktechboston / db_utils

https://pypi.org/project/db-utils/
MIT License
1 stars 1 forks source link

Flora #1

Closed FloraY closed 5 years ago

FloraY commented 5 years ago

added TestPgConnect class

hannaj06 commented 5 years ago

revert back to db_connect from master branch, you have a few bugs in here:

revert dynamodb_connect back to the master branch, the changes you have here don't make anysense

mysql_connect definitely doesn't need psycopg2 imported or default path - don't import packages unless you plan on using it within the class otherwise it clutters up the code unnecessarily

mysql_connect get_df_from_query looks like it was copied from pg_connect and I'm not sure it actually works but I'll have to run your unit test to find out

pg_connect - remove import default_path

s3_connect - revert s3_connect back to master, you removed a critical import statement that would break functionality

same with snowflake connect revert back to master, no need to change this file

same with sql_server_connect.py

revert sqlite_connect back to master you - get_dicts_from_query definitely won't work in this class

with conn.cursor(cursor_factory=psycopg2.extras.RealDictCursor) as cur: don't copy and paste code unless you understand what it does.....