ktgw0316 / LightZone

LightZone is a photo editor for Mac, Windows, and Linux.
BSD 3-Clause "New" or "Revised" License
324 stars 50 forks source link

Canon R7 and 6D Unsupported in 5.0 Beta2 #318

Closed sfink16 closed 1 year ago

sfink16 commented 1 year ago

@ktgw0316 Describe the bug Canon R7 Unsupported in 5.0 Beta2, see attached

To Reproduce Steps to reproduce the behavior: Attempt to open a Canon R7 CR3 raw image Sample R7 CR3 Link, Click HERE Expected behavior Expect image to open without error

Screenshots Screenshot from 2023-09-26 22-31-00

Desktop (please complete the following information):

Additional context From LZ run in terminal: com.lightcrafts.image.BadImageFileException: /media/steve/9630-E17B/Benezette 7-1-23/_W5A8270.CR3: LibRaw Exception (p:7, w:0) at com.lightcrafts.image.libs.LibRaw.getImage(LibRaw.java:385) at com.lightcrafts.image.libs.LibRaw.getImage(LibRaw.java:368) at com.lightcrafts.image.types.RawImageType.getImage(RawImageType.java:118) at com.lightcrafts.image.ImageInfo.getImage(ImageInfo.java:242) at com.lightcrafts.model.ImageEditor.ImageEditorEngine.(ImageEditorEngine.java:179) at com.lightcrafts.model.EngineFactory.createEngine(EngineFactory.java:37) at com.lightcrafts.ui.editor.Document.(Document.java:322) at com.lightcrafts.app.Application.createDocument(Application.java:431) at com.lightcrafts.app.DocumentInitializer$1.run(DocumentInitializer.java:66) at java.base/java.lang.Thread.run(Thread.java:833) Disposing Engine This after successfully editing/opening a Canon R5 (R3 raw image): Opening /media/steve/9630-E17B/EOSR5hSLI000050NR0.CR3 Checking cache for: /media/steve/9630-E17B/EOSR5hSLI000050NR0.CR3 Retrieved Cached image in 5ms daylightMultipliers: 2.0399556, 0.936102, 1.2077353 Daylight Temperature : 10620.0 EventThread blocked for 2.000 seconds

ktgw0316 commented 1 year ago

The sample R7 CR3 can be opened correctly on macOS (Ventura 13.5, Apple M1). I'm going to check it on Ubuntu too.

sfink16 commented 1 year ago

@ktgw0316 I just checked that image and found that it opens with strange colors that can be fixed but I found it odd anyway. It's the other images on my Ubuntu PC that don't open. Could it be a Java issue? I also found an old Canon 6D image is unsupported.. Below is the return from the sample I provided with the weird colors. The other test CR3 image from the Imaging Resource site returns exactly the same and looks even worse. Is Daylight multipliers correct?
Opening /media/steve/9630-E17B/DigiKam/6J8A0080.CR3 Checking cache for: /media/steve/9630-E17B/DigiKam/6J8A0080.CR3 Retrieved Cached image in 7ms daylightMultipliers: 2.0399556, 0.936102, 1.2077353 Daylight Temperature : 10620.0 ### asyncRepaint failed

sfink16 commented 1 year ago

@ktgw0316 EDIT from first sample is NOT a good example. Try this R7 sample from my PC --> Canon R7

sfink16 commented 1 year ago

EDIT for 9/29/23: The Canon R7 image that gave an example for does open on my LZ Beta 2 Windows 10 mini desktop. Oddly Lens Correction does work on the Window 10 desktop.

MJacal commented 1 year ago

Your file, 20230218_0233.CR3, opens here and looks OK, the raw curve still has to be made, but lens corrections are dead - 64-bit Windows 10 desktop.

sfink16 commented 1 year ago

Tex used to do the raw curves for new cameras. Unless someone takes over that role, we are probably on our own. I haven't looked to see if the procedure created by Tex is still out there, since the original site is no longer available. Of course we could use the WayBack Machine to try to find it.

sfink16 commented 1 year ago

@ktgw0316 Is Lightzone.desktop the problem since it doesn't have CR3 but does have CR2, see: Screenshot from 2023-09-30 18-07-48

ktgw0316 commented 1 year ago

@sfink16 I confirmed the LibRaw exception with R7 on Ubuntu 22.04LTS runs in virturalbox.

Canon EOS R3, R7 and R10 are supported since LibRaw 0.21: https://www.libraw.org/news/libraw-0-21-release and Ubuntu (22.04LTS, 22.10, 23.04) only provides libraw20 package: https://packages.ubuntu.com/jammy-updates/libraw20 so there is nothing we can do.

Ubuntu 23.10 switched to LibRaw 0.21, so I think it works fine: https://packages.ubuntu.com/mantic/libraw23 (I don't know why the number is 23 instead of 21.)

sfink16 commented 1 year ago

@sfink16 I confirmed the LibRaw exception with R7 on Ubuntu 22.04LTS runs in virturalbox.

Canon EOS R3, R7 and R10 are supported since LibRaw 0.21: https://www.libraw.org/news/libraw-0-21-release and Ubuntu (22.04LTS, 22.10, 23.04) only provides libraw20 package: https://packages.ubuntu.com/jammy-updates/libraw20 so there is nothing we can do.

Ubuntu 23.10 switched to LibRaw 0.21, so I think it works fine: https://packages.ubuntu.com/mantic/libraw23 (I don't know why the number is 23 instead of 21.)

@ktgw0316

Upgrading to Ubuntu 23.10 doesn't work either because 23.10 tries/dependency to use Libraw20, not libraw23.

I installed The latest Ubuntu 23.10, see: Screenshot from 2023-10-07 11-01-19

with Libraw23 (libraw21, see:

Screenshot from 2023-10-07 11-02-14 But I couldn't remove Libraw20 due to it removing Lightzone, see:

Screenshot from 2023-10-07 11-02-45

Lightzone dependencies list Libraw20, not libraw 23, see:

Screenshot from 2023-10-07 11-04-05

Can you change Lightzone for Ubuntu 23.10 to use/dependency of Libraw21 (libraw23) instead of Libraw20? I think that can fix the problem. Thanks for all your hard work!

ktgw0316 commented 1 year ago

@sfink16 Thanks for testing. I also upgraded to mantic, and it works correctly. So, please make sure:

sfink16 commented 1 year ago

@ktgw0316 I might have a problem with my Ubuntu upgrade. Here is what my apt show lightzone displays:

Screenshot from 2023-10-08 20-00-11

But when I run Lightzone, this is what I get:

Screenshot from 2023-10-08 20-02-23

EDIT : Running Ubuntu 23.10 (Mantic) from a clean flash drive didn't work, giving me the results above.

sfink16 commented 1 year ago

I'm going to close this since it is a known that Ubuntu 22.04 can't work due to being outdated libraw20 versus libraw23. I still have issues noted with Ubuntu 23.10, see Ubuntu 23.10 can't open error. I haven't solved the error but it may be an issue of running a 23.10 app (Lightzone) on a 22.04 installation, I don't know. Either way, I'm going to close this Open Issue and open a new one.