search

kth-ros-pkg / force_torque_tools

Tools for gravity compensation and force-torque sensor calibration.
BSD 3-Clause "New" or "Revised" License
79 stars 50 forks source link

Create jade branch #11

Closed progtologist closed 8 years ago

progtologist commented 8 years ago

I have made some minor changes regarding eigen compatibility with Jade, please create a jade branch so I can issue a pull request.

Thx ;-)

130s commented 8 years ago

Correct me if I'm wrong; there's a migration notice about Eigen in Jade where you still can keep using the same code for Jade and prior distros. So if the change you have is about this cmake, my opinion is to try the solution in the link above to use the same code.

Branching works as a clean solution for the difference between distros, but it can inject disorder unless the repo is maintained consistently (don't get me wrong, I don't mean at all this repo is not maintained. It's just I've seen several repos that fell into a bad loop). 2cents from me.

progtologist commented 8 years ago

I think that the "If you want to support both" part of the sentence refers to jade and k-turtle, but not indigo. I have also changed the preprocessor include paths to be <Eigen/...> (which should be the correct path if the Eigen headers are correctly found using cmake variables) and not <eigen3/Eigen/...>

130s commented 8 years ago

I have also changed the preprocessor include paths to be (which should be the correct path if the Eigen headers are correctly found using cmake variables) and not

I'm not cmake-eigen guru but sounds like this is a good reason to create branch for jade. So +1 I don't have a right to do so. Maybe @fevb

Below is just a comment.

I think that the "If you want to support both" part of the sentence refers to jade and k-turtle, but not indigo.

My impression from the wiki statement was that for the situation described in wiki, we don't need to do anything for Jade.

fevb commented 8 years ago

Hi, sure I'll create a jade branch, sounds reasonable