search

kth-step / HolBA

Binary analysis in HOL
Other
35 stars 21 forks source link

Move to Kananaskis-14 #143

Closed didriklundberg closed 3 years ago

didriklundberg commented 3 years ago

The changes contained required to keep HolBA up-to-date with Kananaskis-14 are very small.

make main and make tests currently compile without errors, we will have to discuss if other things should be ticked off.

andreaslindner commented 3 years ago

I was thinking that we probably want to also add the latest stable polyml and make it the standard build. and drop the older one we have in the CI. After testing this locally, we need to change the CI cache key so that the CI rebuilds the cache with these combinations. The cache key update we need to do either way, but we could combine this now nicely I think.

didriklundberg commented 3 years ago

I was thinking that we probably want to also add the latest stable polyml and make it the standard build. and drop the older one we have in the CI. After testing this locally, we need to change the CI cache key so that the CI rebuilds the cache with these combinations. The cache key update we need to do either way, but we could combine this now nicely I think.

Sure, good idea. Will you fix that and push to this branch or should I do it?

andreaslindner commented 3 years ago

This is the latest polyml: https://github.com/polyml/polyml/releases/tag/v5.8.1

And we could simply drop 5.7 now.

And this is where we need to change the CI cache key: https://github.com/kth-step/HolBA/blob/042cb4cf0ea7d05b0769f950f444c5c2e1159649/.github/workflows/build.yaml#L35

Just add the hol4 version to it after polyml is adapted. The line could then be something like: key: os-${{ runner.os }}_polyml-${{ matrix.polyml }}_hol4-k14

andreaslindner commented 3 years ago

I was thinking that we probably want to also add the latest stable polyml and make it the standard build. and drop the older one we have in the CI. After testing this locally, we need to change the CI cache key so that the CI rebuilds the cache with these combinations. The cache key update we need to do either way, but we could combine this now nicely I think.

Sure, good idea. Will you fix that and push to this branch or should I do it?

Both works for me. If you like to do it, then go ahead. If you like me to do it, I can do that also.

didriklundberg commented 3 years ago

I was thinking that we probably want to also add the latest stable polyml and make it the standard build. and drop the older one we have in the CI. After testing this locally, we need to change the CI cache key so that the CI rebuilds the cache with these combinations. The cache key update we need to do either way, but we could combine this now nicely I think.

Sure, good idea. Will you fix that and push to this branch or should I do it?

Both works for me. If you like to do it, then go ahead. If you like me to do it, I can do that also.

I suggest you do it, you know more about the CI.

andreaslindner commented 3 years ago

Wait, is this info still up to date? https://github.com/kth-step/HolBA/blame/master/README.md#L64

didriklundberg commented 3 years ago

Wait, is this info still up to date? https://github.com/kth-step/HolBA/blame/master/README.md#L64

Hmm... I think 5.7.1 is still the latest version packaged for Ubuntu. So if we upgrade to 5.8.1 we need to keep that in mind when changing this line.