kth-step / HolBA

Binary analysis in HOL
Other
33 stars 20 forks source link

Add symbolic execution, and also fix some issues after the Holmakefile change, reactivated testing and testing with CI #168

Closed andreaslindner closed 4 months ago

andreaslindner commented 4 months ago

The failing CI is due to reactivation of CI testing. It actually fixes several issues.

palmskog commented 4 months ago

@andreaslindner this is fine to merge by me, but maybe the failing test cases in CI can be disabled for the time being, so we get a green checkmark? Then @didriklundberg and I can work on fixing them when Didrik has time.

didriklundberg commented 4 months ago

@andreaslindner this is fine to merge by me, but maybe the failing test cases in CI can be disabled for the time being, so we get a green checkmark? Then @didriklundberg and I can work on fixing them when Didrik has time.

Yes, that would also be fine by me.

guancio commented 4 months ago

I think we need to clarify which tests have to remain and which ones are legacy. The ones that should remain should pass, otherwise we are going to loose functionalities while doing this porting.

palmskog commented 4 months ago

@guancio as we have discussed elsewhere, the following are the tests that were run in CI before:

The following tests are failing after the new CI build in this PR, and I propose that Didrik and I together aim to fix them very soon:

What I propose is that in the interest of merging this PR quickly and having a green build in CI, we temporarily deactivate the failing tests.