Closed andreaslindner closed 4 months ago
@andreaslindner this is fine to merge by me, but maybe the failing test cases in CI can be disabled for the time being, so we get a green checkmark? Then @didriklundberg and I can work on fixing them when Didrik has time.
@andreaslindner this is fine to merge by me, but maybe the failing test cases in CI can be disabled for the time being, so we get a green checkmark? Then @didriklundberg and I can work on fixing them when Didrik has time.
Yes, that would also be fine by me.
I think we need to clarify which tests have to remain and which ones are legacy. The ones that should remain should pass, otherwise we are going to loose functionalities while doing this porting.
@guancio as we have discussed elsewhere, the following are the tests that were run in CI before:
The following tests are failing after the new CI build in this PR, and I propose that Didrik and I together aim to fix them very soon:
What I propose is that in the interest of merging this PR quickly and having a green build in CI, we temporarily deactivate the failing tests.
The failing CI is due to reactivation of CI testing. It actually fixes several issues.