automatic demos broken - Githubissues

kthakore commented 13 years ago

after some time idle in main menu, an automatic demo is normally shown; on console the following line is printed (probably some messup in the file or missing file or whatever):

Incorrect line number 1 in savegame.

kthakore commented 13 years ago

Author: kthakore Time: 1277563435 Field: status Value: closed

kthakore commented 13 years ago

Author: kthakore Time: 1277563435 Field: resolution Value: fixed

kthakore commented 13 years ago

Author: kthakore Time: 1277563435 Field: comment Value: Fixed:

http://imgur.com/lk8bk.png

kthakore commented 13 years ago

Author: gcottenc Time: 1277991809 Field: status Value: reopened

kthakore commented 13 years ago

Author: gcottenc Time: 1277991809 Field: resolution Value:

kthakore commented 13 years ago

Author: gcottenc Time: 1277991809 Field: comment Value: nope, it still doesn't work. I think your detection of perl bz2 module is broken and would need:

@@ -6014,7 +6018,7 @@ sub replay {

                     }
                     else {

$replayfile or print("Module Compress::Bzip2 is missing, not displaying playback.\n"), return;
print("Module Compress::Bzip2 is missing, not displaying playback.\n"), return; } unlink ($filename); } @@ -6033,7 +6037,7 @@ sub replay { $bz->bzclose(); } else {
$replayfile or print("Module Compress::Bzip2 is missing, not displaying playback.\n"), return;
print("Module Compress::Bzip2 is missing, not displaying playback.\n"), return; } } else { $replayfile = cat_($replayfile);

that said, I don't think this approach is too good. usually "bzip2" is installed, but perl modules are not installed by "normal" users, only on hard dependencies. so in this case, most users will never see the demoes, and never see the error message in console btw since they launch apps from graphical icons. so either the old approach should be reverted, or a harder dependency towards perl-Compress-Bzip2 should be used.

kthakore commented 13 years ago

Author: froggs Time: 1278006665 Field: comment Value: bzip2 is usally not installed on Windows machines...

So, making Compress::Bzip2 a dep would be the best way imo.

kthakore commented 13 years ago

Author: kthakore Time: 1278076544 Field: comment Value: What is wrong with making it a hard dep?

kthakore commented 13 years ago

Author: froggs Time: 1278622763 Field: status Value: closed

kthakore commented 13 years ago

Author: froggs Time: 1278622763 Field: resolution Value: fixed

kthakore commented 13 years ago

Author: froggs Time: 1278622763 Field: comment Value: Done. FB noe requires Compress::Bzip2.

kthakore / frozen-bubble

automatic demos broken #42