search

kthakore / frozen-bubble

Making frozen bubble cross platform
http://frozen-bubble.org
GNU General Public License v2.0
149 stars 33 forks source link

prevent instant death #59

Closed nchiapol closed 11 years ago

nchiapol commented 11 years ago

In my games player frequently died by malus bubbles added to positions already at the limit. Often with lots of free space next to a single low tail. After this had annoyed me often enough I tried to adjust the malus generation such that malus bubbles are not placed below the line. (Of course you can still be unlucky and get a malus bubble just above the line right before the whole stack advances...)

I played several test games and it seems to work properly. I did not notice any new problem. It would be nice to get this into the next release, if you think this is an improvement to the game-play too.

kthakore commented 11 years ago

Hey,

Thanks Nicola for this. I will review it shortly. For this patch to be accepted GC (the original developer of the game) will also have to review it. I have attached him to the email.

On Sat, Jun 1, 2013 at 9:32 AM, Nicola Chiapolini notifications@github.comwrote:

In my games player frequently died by malus bubbles added to positions already at the limit. Often with lots of free space next to a single low tail. After this had annoyed me often enough I tried to adjust the malus generation such that malus bubbles are not placed below the line. (Of course you can still be unlucky and get a malus bubble just above the line right before the whole stack advances...)

I played several test games and it seems to work properly. I did not notice any new problem. It would be nice to get this into the next release, if you think this is

an improvement to the game-play too.

You can merge this Pull Request by running

git pull https://github.com/nchiapol/frozen-bubble master

Or view, comment on, or merge it at:

https://github.com/kthakore/frozen-bubble/pull/59 Commit Summary

  • change malus generation to prevent instant death

File Changes

  • M bin/frozen-bubblehttps://github.com/kthakore/frozen-bubble/pull/59/files#diff-0(30)

Patch Links:

gcottenc commented 11 years ago

Hi,

Regularly I had complaints that malus bubbles "stick to the lowest point" and possibly make people lose. The truth is malus bubbles are located randomly. Specifically avoiding some lower positions doesn't look logical to me. If it's really going to be included it should be a commandline switch and not enabled by default.

Thanks

On Sat, Jun 1, 2013 at 3:32 PM, Nicola Chiapolini notifications@github.comwrote:

In my games player frequently died by malus bubbles added to positions already at the limit. Often with lots of free space next to a single low tail. After this had annoyed me often enough I tried to adjust the malus generation such that malus bubbles are not placed below the line. (Of course you can still be unlucky and get a malus bubble just above the line right before the whole stack advances...)

I played several test games and it seems to work properly. I did not notice any new problem. It would be nice to get this into the next release, if you think this is

an improvement to the game-play too.

You can merge this Pull Request by running

git pull https://github.com/nchiapol/frozen-bubble master

Or view, comment on, or merge it at:

https://github.com/kthakore/frozen-bubble/pull/59 Commit Summary

  • change malus generation to prevent instant death

File Changes

  • M bin/frozen-bubblehttps://github.com/kthakore/frozen-bubble/pull/59/files#diff-0(30)

Patch Links:

Guillaume Cottenceau

kthakore commented 11 years ago

@gcottenc: Thanks for your input @nchiapol : if you can meet GC's specs and make it a command line switch. I will merge it.

On Sun, Jun 2, 2013 at 3:38 PM, gcottenc notifications@github.com wrote:

Hi, Regularly I had complaints that malus bubbles "stick to the lowest point" and possibly make people lose. The truth is malus bubbles are located randomly. Specifically avoiding some lower positions doesn't look logical to me. If it's really going to be included it should be a commandline switch and not enabled by default. Thanks On Sat, Jun 1, 2013 at 3:32 PM, Nicola Chiapolini notifications@github.comwrote:

In my games player frequently died by malus bubbles added to positions already at the limit. Often with lots of free space next to a single low tail. After this had annoyed me often enough I tried to adjust the malus generation such that malus bubbles are not placed below the line. (Of course you can still be unlucky and get a malus bubble just above the line right before the whole stack advances...)

I played several test games and it seems to work properly. I did not notice any new problem. It would be nice to get this into the next release, if you think this is

an improvement to the game-play too.

You can merge this Pull Request by running

git pull https://github.com/nchiapol/frozen-bubble master

Or view, comment on, or merge it at:

https://github.com/kthakore/frozen-bubble/pull/59 Commit Summary

  • change malus generation to prevent instant death

File Changes

  • M bin/frozen-bubblehttps://github.com/kthakore/frozen-bubble/pull/59/files#diff-0(30)

Patch Links:

Guillaume Cottenceau

Reply to this email directly or view it on GitHub: https://github.com/kthakore/frozen-bubble/pull/59#issuecomment-18812305

nchiapol commented 11 years ago

@Nicola: if you can meet GC's specs and make it a command line switch. I will merge it. Not sure if you get notified about commits. So here an additional message: I pushed a commit yesterday morning that adds a command line switch (off by default) to activate my change.

In addition I just wanted to point out, that I tried to keep my change minimal. So the malus bubbles are still located randomly, but positions leading to an instant death are avoided. The command line switch surely is the proper way to handle this.

Is there anything else I should adjust?