search

kthcloud / console

kthcloud web console
https://cloud.cbh.kth.se
MIT License
3 stars 4 forks source link

Make secrets a bit more secret in the CLI box #244

Closed saffronjam closed 5 months ago

saffronjam commented 5 months ago

Right now we hide the Docker secrets in the GitHub actions box. However, the Docker CLI commands (Right above) still has the secrets visible.

Maybe the button can copy the commands with the secrets, and then hide them in the GUI?

image

pierrelefevre commented 5 months ago

that's a nice deployment you got there

pierrelefevre commented 5 months ago

Thanks for pointing this out, would be easy for some secrets to slip into a screenshot. Imagine what someone could do to that deployment

pierrelefevre commented 5 months ago

like IMAGINE https://test-deployment.app.cloud.cbh.kth.se/

saffronjam commented 5 months ago

I just wanted to show you the DANGER of showing secrets