Closed Phillezi closed 1 month ago
Huh seems my commit didn't make it, but I edited the spacing to 1 (brings the button closer to the Status view, and added size="small" to the IconButton.
I wonder if it might be beneficial to remove the black border when showing many replicas, seems it gets pretty aliased otherwise?
Hi! Thanks for the feedback
MenuItem
to Typography
(not clickable anymore) .Does this look good, or should i change anything?
Havent done the border removal on large amounts yet, but will start with that now
Nice! Maybe some more margin below the header would look good, could base it off the Menu component
Nice! Maybe some more margin below the header would look good, could base it off the Menu component
(divider might be unnecessary but do whatever looks best to you :D)
Added some more margin and changed the color of the divider, looks like this now:
If there are 20 or more replicas the gap/border gets removed:
Looking good! This will be a great addition to the console. Thanks for your work :)
Thanks! :)
272
Shows the status of a deployments replicas, (if replicas > 1)
The different statuses
readyReplicas
for replicas that are ready, no current action (showed in green)availableReplicas - readyReplicas
for replicas that are doing something (showed in blue)unavailableReplicas
for replicas that are unavailable. (showed in red)desiredReplicas - (availableReplicas + unavailableReplicas)
for replicas that the user wants but doesnt exist. (showed in grey[800], light grey on dark-mode and dark grey on light mode)What have i done
ReplicaStatus.tsx
that is displayed inside theEdit.tsx
top bar that gets rendered if theresource.type
is deployment and there are> 1
replicas on that deployment.en.json
andse.json
for the labels used to describe the statuses.Screenshots
Deployments with short names
Deployments with longer names
Heres how it looks with more statuses
With many replicas
i18n locale status labels