kthcloud / console

kthcloud web console
https://cloud.cbh.kth.se
MIT License
3 stars 3 forks source link

Show replica status, closes #272 #282

Closed Phillezi closed 1 month ago

Phillezi commented 1 month ago

272

Shows the status of a deployments replicas, (if replicas > 1)

The different statuses

What have i done

Screenshots

Deployments with short names

Screenshot from 2024-05-20 22-48-51

Deployments with longer names

Screenshot from 2024-05-20 22-49-02

Heres how it looks with more statuses

Screenshot from 2024-05-20 23-03-06

With many replicas

Screenshot from 2024-05-20 23-04-47

i18n locale status labels

image

pierrelefevre commented 1 month ago

Huh seems my commit didn't make it, but I edited the spacing to 1 (brings the button closer to the Status view, and added size="small" to the IconButton.

pierrelefevre commented 1 month ago

I wonder if it might be beneficial to remove the black border when showing many replicas, seems it gets pretty aliased otherwise?

Phillezi commented 1 month ago

Hi! Thanks for the feedback

Does this look good, or should i change anything? image image

Havent done the border removal on large amounts yet, but will start with that now

pierrelefevre commented 1 month ago

Nice! Maybe some more margin below the header would look good, could base it off the Menu component

image
pierrelefevre commented 1 month ago

Nice! Maybe some more margin below the header would look good, could base it off the Menu component image

(divider might be unnecessary but do whatever looks best to you :D)

Phillezi commented 1 month ago

Added some more margin and changed the color of the divider, looks like this now:

image

image

Edit, forgot to mention:

If there are 20 or more replicas the gap/border gets removed: image image

pierrelefevre commented 1 month ago

Looking good! This will be a great addition to the console. Thanks for your work :)

Phillezi commented 1 month ago

Thanks! :)