search

kthcloud / go-deploy

Creation and management of resources on kthcloud
https://api.cloud.cbh.kth.se/deploy
MIT License
3 stars 1 forks source link

Custom domain length too long for verification #526

Closed pierrelefevre closed 2 months ago

pierrelefevre commented 2 months ago

When using a long domain, the verification cannot be performed since it requires "_kthcloud." to be prepended, adding 10 characters.

The custom domain max length should therefore be 253-10 or 243

saffronjam commented 2 months ago

What about a name that require puny-encoding? 🤔

Maybe we should just make it like 200 to be a bit more safe.

Or I could require the name to be less than 243 after puny encoding. That could also work I guess

pierrelefevre commented 2 months ago

+1 for after encoding, might be nice with an error message for that edge case