search

ktindiana / sphinxval

SPHINX validation code for solar energetic particle models
MIT License
3 stars 3 forks source link

Checking for repeat forecasts #41

Open ktindiana opened 8 months ago

ktindiana commented 8 months ago

Checking should be implemented to look for repeated forecasts or forecasts from the same model covering exactly the same prediction window in the same energy channel. e.g. ADEPT 1hr and 6hr forecasts wrote over each other because they had the same short name and forecast periods.

This will additionally likely identify a number of MAG4 forecasts as it has the behavior of repeating exactly the last forecast if no new data has been received.

rickyegeland commented 8 months ago

What should the behavior of the check be? Crash when found? Create a unique ID and count them all?

ktindiana commented 6 months ago

Yes, what should the behavior be and what should we check? What should be unique? Issue time, prediction window, forecasted values? What if the issue time is different but all the other values remain the same (as in the MAG4 behavior)? What should be considered a valid repeat and what is not?

ktindiana commented 6 months ago

Marking with "Help wanted" label to determine appropriate logic, then I will code it up.