search

ktindiana / sphinxval

SPHINX validation code for solar energetic particle models
MIT License
3 stars 3 forks source link

Error in HSS #54

Closed rickyegeland closed 5 months ago

rickyegeland commented 5 months ago

In metrics.py calc_contingency_bool() the HSS metric has a sign error. It should be:

'HSS': check_div(2.0 * (h*c - f*m), ((h+m) * (m+c) + (h+f) * (f+c))),

It was corrected in calc_contingency() above, but not here in the function that is actually used in validation.py.

claya71 commented 5 months ago

Fixed, will push changes to metrics.py after implementation of Brier Skill Score using last SC climatology rate

ktindiana commented 5 months ago

Verified that Clayton fixed this and it was included in the merge.