search

ktisha / Crucible4IDEA

Crucible plugin for IntelliJ IDEA
MIT License
59 stars 26 forks source link

Revision will be missed if it contains an ADDED file, which was MODIFIED in one of the next revisions included into the review #16

Closed klikh closed 11 years ago

klikh commented 11 years ago

Currently plugin takes all revisions mentioned in the XML and subtracts all fromRevisions mentioned there. Normally, if a file was ADDED in a commit, it doesn't have fromRevisions it the reviewItem associated with this file. But if this file was further modified in one of other commits included to the revision, reviewItem gains the fromRevision tag which points to that commit initial for this file.

Example: intellij project crucible instance, review CR-IC-356: the plugin doesn't report bae1b65 although this revision is included into the review.

klikh commented 11 years ago

--After investigation we decided that this works correctly, because added files don't have {{fromRevision}}.-- More investigation - and the problem was finally found.