search

ktisha / Crucible4IDEA

Crucible plugin for IntelliJ IDEA
MIT License
59 stars 26 forks source link

add attached patch files into consideration #35

Closed denis-zhdanov closed 11 years ago

denis-zhdanov commented 11 years ago

Tried to open my review (CR-IC-705). Got 'fatal: Invalid object name '3'.' at the Messages tool window and corresponding tab doesn't show any information - https://dl.dropboxusercontent.com/u/1648086/screenshot/review.png.

idea.log contains the following relevant info:

2013-04-18 13:42:32,099 [ 183996] INFO - git4idea.commands.GitHandler - cd /home/denis/work/ultimate 2013-04-18 13:42:32,099 [ 183996] INFO - git4idea.commands.GitHandler - git show --name-status -M --pretty=format:%x01%h%x02%H%x02%ct%x02%an%x02%at%x02%ae%x02%cn%x02%ce%x02%p%x02%d%x02%s%x02%b%x02%B%x03 --encoding=UTF-8 6:T 2013-04-18 13:42:32,124 [ 184021] INFO - git4idea.commands.GitHandler - fatal: Invalid object name '6'. 2013-04-18 13:42:32,143 [ 184040] INFO - git4idea.commands.GitHandler - cd /home/denis/work/ultimate 2013-04-18 13:42:32,143 [ 184040] INFO - git4idea.commands.GitHandler - git show --name-status -M --pretty=format:%x01%h%x02%H%x02%ct%x02%an%x02%at%x02%ae%x02%cn%x02%ce%x02%p%x02%d%x02%s%x02%b%x02%B%x03 --encoding=UTF-8 4:T 2013-04-18 13:42:32,162 [ 184059] INFO - git4idea.commands.GitHandler - fatal: Invalid object name '4'. 2013-04-18 13:42:32,170 [ 184067] INFO - git4idea.commands.GitHandler - cd /home/denis/work/ultimate 2013-04-18 13:42:32,171 [ 184068] INFO - git4idea.commands.GitHandler - git show --name-status -M --pretty=format:%x01%h%x02%H%x02%ct%x02%an%x02%at%x02%ae%x02%cn%x02%ce%x02%p%x02%d%x02%s%x02%b%x02%B%x03 --encoding=UTF-8 11:T 2013-04-18 13:42:32,189 [ 184086] INFO - git4idea.commands.GitHandler - fatal: Invalid object name '11'. 2013-04-18 13:42:32,194 [ 184091] INFO - git4idea.commands.GitHandler - cd /home/denis/work/ultimate 2013-04-18 13:42:32,194 [ 184091] INFO - git4idea.commands.GitHandler - git show --name-status -M --pretty=format:%x01%h%x02%H%x02%ct%x02%an%x02%at%x02%ae%x02%cn%x02%ce%x02%p%x02%d%x02%s%x02%b%x02%B%x03 --encoding=UTF-8 9:T 2013-04-18 13:42:32,207 [ 184104] INFO - git4idea.commands.GitHandler - fatal: Invalid object name '9'. 2013-04-18 13:42:32,211 [ 184108] INFO - git4idea.commands.GitHandler - cd /home/denis/work/ultimate 2013-04-18 13:42:32,211 [ 184108] INFO - git4idea.commands.GitHandler - git show --name-status -M --pretty=format:%x01%h%x02%H%x02%ct%x02%an%x02%at%x02%ae%x02%cn%x02%ce%x02%p%x02%d%x02%s%x02%b%x02%B%x03 --encoding=UTF-8 2:T 2013-04-18 13:42:32,224 [ 184121] INFO - git4idea.commands.GitHandler - fatal: Invalid object name '2'. 2013-04-18 13:42:32,228 [ 184125] INFO - git4idea.commands.GitHandler - cd /home/denis/work/ultimate 2013-04-18 13:42:32,228 [ 184125] INFO - git4idea.commands.GitHandler - git show --name-status -M --pretty=format:%x01%h%x02%H%x02%ct%x02%an%x02%at%x02%ae%x02%cn%x02%ce%x02%p%x02%d%x02%s%x02%b%x02%B%x03 --encoding=UTF-8 10:T 2013-04-18 13:42:32,245 [ 184142] INFO - git4idea.commands.GitHandler - fatal: Invalid object name '10'. 2013-04-18 13:42:32,254 [ 184151] INFO - git4idea.commands.GitHandler - cd /home/denis/work/ultimate 2013-04-18 13:42:32,254 [ 184151] INFO - git4idea.commands.GitHandler - git show --name-status -M --pretty=format:%x01%h%x02%H%x02%ct%x02%an%x02%at%x02%ae%x02%cn%x02%ce%x02%p%x02%d%x02%s%x02%b%x02%B%x03 --encoding=UTF-8 5:T 2013-04-18 13:42:32,272 [ 184169] INFO - git4idea.commands.GitHandler - fatal: Invalid object name '5'. 2013-04-18 13:42:32,281 [ 184178] INFO - git4idea.commands.GitHandler - cd /home/denis/work/ultimate 2013-04-18 13:42:32,281 [ 184178] INFO - git4idea.commands.GitHandler - git show --name-status -M --pretty=format:%x01%h%x02%H%x02%ct%x02%an%x02%at%x02%ae%x02%cn%x02%ce%x02%p%x02%d%x02%s%x02%b%x02%B%x03 --encoding=UTF-8 1:T 2013-04-18 13:42:32,300 [ 184197] INFO - git4idea.commands.GitHandler - fatal: Invalid object name '1'. 2013-04-18 13:42:32,309 [ 184206] INFO - git4idea.commands.GitHandler - cd /home/denis/work/ultimate 2013-04-18 13:42:32,309 [ 184206] INFO - git4idea.commands.GitHandler - git show --name-status -M --pretty=format:%x01%h%x02%H%x02%ct%x02%an%x02%at%x02%ae%x02%cn%x02%ce%x02%p%x02%d%x02%s%x02%b%x02%B%x03 --encoding=UTF-8 0:T 2013-04-18 13:42:32,328 [ 184225] INFO - git4idea.commands.GitHandler - fatal: Invalid object name '0'. 2013-04-18 13:42:32,333 [ 184230] INFO - git4idea.commands.GitHandler - cd /home/denis/work/ultimate 2013-04-18 13:42:32,333 [ 184230] INFO - git4idea.commands.GitHandler - git show --name-status -M --pretty=format:%x01%h%x02%H%x02%ct%x02%an%x02%at%x02%ae%x02%cn%x02%ce%x02%p%x02%d%x02%s%x02%b%x02%B%x03 --encoding=UTF-8 7:T 2013-04-18 13:42:32,346 [ 184243] INFO - git4idea.commands.GitHandler - fatal: Invalid object name '7'. 2013-04-18 13:42:32,350 [ 184247] INFO - git4idea.commands.GitHandler - cd /home/denis/work/ultimate 2013-04-18 13:42:32,350 [ 184247] INFO - git4idea.commands.GitHandler - git show --name-status -M --pretty=format:%x01%h%x02%H%x02%ct%x02%an%x02%at%x02%ae%x02%cn%x02%ce%x02%p%x02%d%x02%s%x02%b%x02%B%x03 --encoding=UTF-8 8:T 2013-04-18 13:42:32,368 [ 184265] INFO - git4idea.commands.GitHandler - fatal: Invalid object name '8'. 2013-04-18 13:42:32,373 [ 184270] INFO - git4idea.commands.GitHandler - cd /home/denis/work/ultimate 2013-04-18 13:42:32,373 [ 184270] INFO - git4idea.commands.GitHandler - git show --name-status -M --pretty=format:%x01%h%x02%H%x02%ct%x02%an%x02%at%x02%ae%x02%cn%x02%ce%x02%p%x02%d%x02%s%x02%b%x02%B%x03 --encoding=UTF-8 3:T 2013-04-18 13:42:32,392 [ 184289] INFO - git4idea.commands.GitHandler - fatal: Invalid object name '3'.

ktisha commented 11 years ago

Review for patch doesn't contain expected git hash in

denis-zhdanov commented 11 years ago

Ok. Feature request then - add into consideration attached patch files :)

klikh commented 11 years ago

Reviews with patch files are now supported.