search

ktisha / Crucible4IDEA

Crucible plugin for IntelliJ IDEA
MIT License
59 stars 26 forks source link

Agile style review support #57

Closed alexey-zaharchenko closed 9 years ago

alexey-zaharchenko commented 11 years ago

It's look like there isn't agile style review support, only review with moderator. Then i click "Out For Review" NPE happens:

null java.lang.NullPointerException at com.jetbrains.crucible.connection.CrucibleApi.parseReview(CrucibleApi.java:53) at com.jetbrains.crucible.connection.CrucibleSessionImpl.getReviewsForFilter(CrucibleSessionImpl.java:322) at com.jetbrains.crucible.connection.CrucibleManager.getReviewsForFilter(CrucibleManager.java:52) at com.jetbrains.crucible.ui.toolWindow.CrucibleReviewModel.updateModel(CrucibleReviewModel.java:61) at com.jetbrains.crucible.ui.toolWindow.tree.CrucibleOutForReviewNode.handleSelection(CrucibleOutForReviewNode.java:38) at com.intellij.ui.treeStructure.SimpleTree$1.valueChanged(SimpleTree.java:81) at javax.swing.tree.DefaultTreeSelectionModel.fireValueChanged(DefaultTreeSelectionModel.java:629) at com.intellij.ui.treeStructure.Tree$MySelectionModel.fireValueChanged(Tree.java:651) at javax.swing.tree.DefaultTreeSelectionModel.notifyPathChange(DefaultTreeSelectionModel.java:1078) at javax.swing.tree.DefaultTreeSelectionModel.setSelectionPaths(DefaultTreeSelectionModel.java:287) at javax.swing.tree.DefaultTreeSelectionModel.setSelectionPath(DefaultTreeSelectionModel.java:170) at javax.swing.JTree.setSelectionPath(JTree.java:1598) at javax.swing.plaf.basic.BasicTreeUI.selectPathForEvent(BasicTreeUI.java:2311) at javax.swing.plaf.basic.BasicTreeUI$Handler.handleSelection(BasicTreeUI.java:3520) at javax.swing.plaf.basic.BasicTreeUI$Handler.mousePressed(BasicTreeUI.java:3459) at java.awt.AWTEventMulticaster.mousePressed(AWTEventMulticaster.java:262) at java.awt.AWTEventMulticaster.mousePressed(AWTEventMulticaster.java:262) at java.awt.AWTEventMulticaster.mousePressed(AWTEventMulticaster.java:262) at java.awt.AWTEventMulticaster.mousePressed(AWTEventMulticaster.java:262) at java.awt.AWTEventMulticaster.mousePressed(AWTEventMulticaster.java:262) at java.awt.AWTEventMulticaster.mousePressed(AWTEventMulticaster.java:262) at java.awt.Component.processMouseEvent(Component.java:6411) at javax.swing.JComponent.processMouseEvent(JComponent.java:3275) at com.intellij.ui.treeStructure.Tree.processMouseEvent(Tree.java:420) at java.awt.Component.processEvent(Component.java:6179) at java.awt.Container.processEvent(Container.java:2083) at java.awt.Component.dispatchEventImpl(Component.java:4776) at java.awt.Container.dispatchEventImpl(Container.java:2141) at java.awt.Component.dispatchEvent(Component.java:4604) at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4619) at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4277) at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4210) at java.awt.Container.dispatchEventImpl(Container.java:2127) at java.awt.Window.dispatchEventImpl(Window.java:2489) at java.awt.Component.dispatchEvent(Component.java:4604) at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:717) at java.awt.EventQueue.access$400(EventQueue.java:82) at java.awt.EventQueue$2.run(EventQueue.java:676) at java.awt.EventQueue$2.run(EventQueue.java:674) at java.security.AccessController.doPrivileged(Native Method) at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:86) at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:97) at java.awt.EventQueue$3.run(EventQueue.java:690) at java.awt.EventQueue$3.run(EventQueue.java:688) at java.security.AccessController.doPrivileged(Native Method) at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:86) at java.awt.EventQueue.dispatchEvent(EventQueue.java:687) at com.intellij.ide.IdeEventQueue.d(IdeEventQueue.java:679) at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:503) at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:332) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188) at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

I sniff JSON server respond: {"reviewData":[{"projectKey":"I-REPLACE_IT4OBUSFACTION","name":"............ review ........ I-REPLACE_IT4OBUSFACTION-12692","description":"","author":{"userName":"daedmen","displayName":"Zakharchenko Alexey","avatarUrl":"https://domain.com/fisheye/avatar/daedmen?s=48","url":"/fisheye//user/daedmen"},"creator":{"userName":"daedmen","displayName":"Zakharchenko Alexey","avatarUrl":"https://domain.com/fisheye/avatar/daedmen?s=48","url":"/fisheye//user/daedmen"},"permaId":{"id":"I-REPLACE_IT4OBUSFACTION-1"},"permaIdHistory":["I-REPLACE_IT4OBUSFACTION-1"],"state":"Review","type":"REVIEW","allowReviewersToJoin":false,"metricsVersion":3,"createDate":"2013-09-03T17:05:16.867+0400"}]}