search

ktisis-tools / Ktisis

A robust posing tool for creating screenshots in FFXIV's GPose mode.
GNU General Public License v3.0
196 stars 50 forks source link

Added more Translation for DE #83

Open StoiaCode opened 1 year ago

StoiaCode commented 1 year ago

Also cleaned up de_DE to be more in line with en_US Checkcheck?

StoiaCode commented 1 year ago

Tried to implement them.

will it correctly parse the \n from the locals? I implemented it in three parts since that was how it was in the original.

As for Estoy, thats me. Hi. I changed my name. :D Sorry

Fayti1703 commented 1 year ago

will it correctly parse the \n from the locals?

JSON has support for \n, so yes. It will parse those as a newline.

As for Estoy, thats me. Hi. I changed my name. :D Sorry

Oh, I see. My bad.

Fayti1703 commented 1 year ago

Going to reserve this PR for a larger rebase (mainly bringing it up to date and splitting the changes into their own commits where appropriate).

You don't need to do anything, though if you could refrain from pushing additional changes, that'd be appreciated (though I suspect you didn't have plans for that anyway).

I'll keep the resulting combined diff pretty close to what is currently there, though I might add some comments where appropriate afterwards.

StoiaCode commented 1 year ago

I've been waiting for the rework to continue translation :) so go ahead, I'll be picking up once you guys let me know it's 'ready' again :D

Fayti1703 commented 1 year ago

Urgh, I messed up a force-push and GitHub auto-closed the PR because there's no changes, which also prevents me from pushing the correct changeset up. (And it doesn't let me re-open the PR because no changes)

Could you add me as a collaborator on your fork, @StoiaCode?

StoiaCode commented 1 year ago

Done!