search

ktls / af_ktls

Linux Kernel TLS/DTLS Module
GNU General Public License v2.0
157 stars 25 forks source link

sendpage cleanup #81

Closed djwatson closed 8 years ago

djwatson commented 8 years ago

Minor cleanup. tls_sendpage will never receive more than one page, verified by looking at other kernel sources. Remove the extra while loops.

fridex commented 8 years ago

tls_sendpage will never receive more than one page

I'm not sure wit this one. Have you tried splice() from a pipe to AF_KTLS socket with size > PAGE_SIZE? IIRC, I received size > PAGE_SIZE. I cannot check it now thought.

djwatson commented 8 years ago

Yea I think this is actually wrong because of compound pages. There will never be more than one compound page, which works fine with skbs, but scatterlists don't work with compound pages.