ktnrg45 / pyremoteplay

Python API for using PlayStation Remote Play
https://pyremoteplay.readthedocs.io/
GNU General Public License v3.0
29 stars 11 forks source link

controller: Wrap sequence numbers when they exceed 65535 #14

Open Entropy512 opened 1 year ago

Entropy512 commented 1 year ago

Otherwise we enter a persistent error state where we keep on trying to pack numbers greater than 63335 into an unsigned int16

My controller polling rate must be much higher than ktnrg45? My sessions die after a minute or two without this...

DevelopIdeas commented 1 year ago

This Pull request works from my testing

Entropy512 commented 1 year ago

Yeah, sadly does not entirely fix the issues I found. I have some PoC code to fix https://github.com/ktnrg45/pyremoteplay/issues/16 which improved the issues I was having (no spontaneous random button presses), but it seems like after a certain period of time (not very long), something happens (crypto desync?) that causes the PS5 to register what is best described as a seizure of multiple phantom button presses followed by it no longer responding to any presses. It definitely seemed to worsen when using the L2/R2 triggers (which send multiple updates per press since it's not a simple press but two additional axis updates)

PoC is buried in https://github.com/Entropy512/pyremoteplay/commits/hax

I'm sensing this repo is abandoned by ktrng45 - not sure if due to known issues like the ones we've experienced that weren't resolved, or something else. Some info on known state/known issues as of the last release would be beneficial.

DevelopIdeas commented 1 year ago

Yeah, I'm frequently experiencing the same issue with the garbage commands, normally end up sending the audio mute through, then locks up. I'm trying to debug with little success.

natrix5369 commented 1 year ago

Yeah, sadly does not entirely fix the issues I found. I have some PoC code to fix #16 which improved the issues I was having (no spontaneous random button presses), but it seems like after a certain period of time (not very long), something happens (crypto desync?) that causes the PS5 to register what is best described as a seizure of multiple phantom button presses followed by it no longer responding to any presses. It definitely seemed to worsen when using the L2/R2 triggers (which send multiple updates per press since it's not a simple press but two additional axis updates)

PoC is buried in https://github.com/Entropy512/pyremoteplay/commits/hax

I'm sensing this repo is abandoned by ktrng45 - not sure if due to known issues like the ones we've experienced that weren't resolved, or something else. Some info on known state/known issues as of the last release would be beneficial.

thanks! u save my life and my brain. Very thanks