search

ktorio / ktor-build-plugins

Ktor Plugins for Build Systems
Apache License 2.0
56 stars 10 forks source link

Configure publishImage for GitLab Container registry. #74

Closed singh05 closed 1 year ago

singh05 commented 1 year ago

How to setup publishing for GitLab container registry? I cant find any example.

dcowley commented 1 year ago

Hey @singh05, I've opened pull request #77 which will allow you to configure publishImage for external registries like GitLab container registry.

Burtan commented 1 year ago

DockerImageRegistry.externalRegistry() creates invalid urls for me, as it uses the value "image" as part of the url. Image always contains the localImageName and the imageTag seperated by the invalid character ":".

Burtan commented 1 year ago

According to the jib manual and here jib.to.image should not contain any tags, but this plugin sets jib.to.image to fullExternalImageName = externalRegistry.flatMap { it.toImage }.zipWithTag(imageTag).

e5l commented 1 year ago

Thanks, merged!

Stexxe commented 1 year ago

The fix reverted in https://github.com/ktorio/ktor-build-plugins/pull/96 because of the failed tests.

Burtan commented 1 year ago

My commit was reverted although it was independent from the failing tests due to upgraded dependencies?

e5l commented 1 year ago

The problem was with the configuration cache. Now it is fixed and will be published in the next release. Sorry for the inconvenience.