search

ktorio / ktor-build-plugins

Ktor Plugins for Build Systems
Apache License 2.0
56 stars 10 forks source link

Create a flexible external registry builder (#74) #77

Closed dcowley closed 1 year ago

dcowley commented 1 year ago

The only options for configuring an external DockerImageRegistry are Docker Hub and Google Container Registry. We want the ability to support other registries, like GitLab Container Registry.

This change introduces a flexible builder function to configure an external registry comprised of the following components:

  1. Project
  2. Namespace (optional)
  3. Hostname (optional)

The external registry supports the following image naming convention:

<registry URL>/<namespace>/<project>

For example, these are all supported names for container images:

com.registry.example/mynamespace/myproject
com.registry.example/myproject
mynamespace/myproject
dcowley commented 1 year ago

Hi @Stexxe, @e5l

Would you please review this change when you have a chance?

Thanks

dcowley commented 1 year ago

Hi @Stexxe, @e5l

Please review this PR?

Thanks

e5l commented 1 year ago

Hey @dcowley! Thanks for the PR. Merged