search

ktorio / ktor

Framework for quickly creating connected applications in Kotlin with minimal effort
https://ktor.io
Apache License 2.0
12.78k stars 1.04k forks source link

Feature: Ktor websocket client with Stomp #1159

Open guenhter opened 5 years ago

guenhter commented 5 years ago

Ktor Version

1.2.1

Ktor Engine Used(client or server and name)

client-websocket

JVM Version, Operating System and Relevant Context

Feedback

I tried to consume a websocket server with the ktor-client-websocket but it didn't work. It turned out, that the server uses Stomp. It would be nice to support Stomp for the Websocket Client as well here with Ktor. (I was forced to use Spring Websocket as client library).

e5l commented 5 years ago

Hi @guenhter, thanks for the report. It would be nice feature.

talham7391 commented 5 years ago

I can try implementing this

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity.

oleg-larshin commented 4 years ago

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

ArchangelX360 commented 2 years ago

@joffrey-bion will it make sense to "merge" in some ways https://github.com/joffrey-bion/krossbow to ktor-client-websocket?

joffrey-bion commented 2 years ago

@ArchangelX360 Krossbow's STOMP client already supports Ktor as a possible web socket engine with krossbow-websocket-ktor, as mentioned in the YT issue.

It could be a possibility to merge the STOMP support with Ktor, but Krossbow supports more platforms at the moment (e.g. iOS), and other websocket implementations as well, such as Spring and SockJS. I'd be happy to contribute, though!