search

ktorio / ktor

Framework for quickly creating connected applications in Kotlin with minimal effort
https://ktor.io
Apache License 2.0
12.86k stars 1.04k forks source link

Fix compatibility with Clang 16 for C code in nix threadUtils.def #4098

Closed SvyatoslavScherbina closed 3 months ago

SvyatoslavScherbina commented 3 months ago

ktor-utils/nix/interop/threadUtils.def has some C code which is internally compiled by Clang from the LLVM bundled with K/N.

This C code uses printf and includes printf.h to get the declaration. Apparently, printf.h doesn't declare printf function, stdio.h does. So, this causes an implicit declaration warning (-Wimplicit-function-declaration) with Clang 11 (currently used in K/N). With updating to Clang 16, this warning becomes an error, so the code no longer compiles.

This commit replaces printf.h by stdio.h and thus fixes the problem.

KT-49279

Subsystem ktor-utils

Motivation This PR prepares ktor compilation for Kotlin 2.1.0 where we intend to merge the update to LLVM 16. https://youtrack.jetbrains.com/issue/KT-49279/Kotlin-Native-update-LLVM-from-11.1.0-to-16.0.0-or-newer

Solution See above.

SvyatoslavScherbina commented 3 months ago

Thanks! JFTR: I'm not authorized to merge this pull request (and anyway have no idea how to check it on the CI properly). @marychatte Could you please take care of that?

marychatte commented 3 months ago

@SvyatoslavScherbina Yes, I will check CI and then merge