ktor-html-builder: exceptions in DSL are swallowed when StatusPages feature is installed

ktorio / ktor

Framework for quickly creating connected applications in Kotlin with minimal effort

https://ktor.io

Apache License 2.0

12.53k stars 1.02k forks source link

ktor-html-builder: exceptions in DSL are swallowed when StatusPages feature is installed #541

Closed marshallpierce closed 1 year ago

marshallpierce commented 5 years ago

Simple demo:

https://github.com/ktorio/ktor-samples/compare/master...marshallpierce:html-builder-status-pages-swallows-exceptions?expand=1

Expected behavior: I would expect the default to involve a 500 and the exception being logged somewhere, hopefully customizable via StatusPages. Rendering part of the DSL's execution with a 200 is highly misleading, to say the least.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity.

oleg-larshin commented 3 years ago

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.