search

ktosiek / pytest-vcr

Py.test integration with VCR.py
MIT License
154 stars 25 forks source link

problem in cassette_name #24

Open cle-b opened 5 years ago

cle-b commented 5 years ago

Hi Tomasz,

First, thank you for the pytest-vcr plugin :)

I have a small problem in one of my project with the cassette name. Some of my tests have pytest parameters that include a slash ”/” so it’s impact the cassette_name (in fact, that create a directory).

I have fixed this problem by replacing the “/” (and others forbidden characters in filename in Windows) by a dash “-”.

Here it’s a PR for this fix.

I wish the fix could be integrated in pytest-vcr. I will be happy to contribute to this plugin.

Have a good day,

Regards,

Clément

cle-b commented 5 years ago

...hum… the build failed for Windows… It’s embarrassing :( Sorry, I'm going to investigate.

cle-b commented 5 years ago

The problem in the build for Python 2.7 on Windows come from appveyor. I have fixed this issue by reinstalling virtualenv. Without that, tox use an old pip version that install some packages in versions that are not compatible with python 2.7.