ktquez / vue-disqus

Integrate Disqus count and comments in your application Vue 3, with support for SPA
https://ktquez.github.io/vue-disqus/
MIT License
253 stars 26 forks source link

Shouldn't the dist files be in ES5? #32

Closed pxwee5 closed 4 years ago

pxwee5 commented 5 years ago

A lot of people use exclude: /node_module/ in their .js and .vue rules. And the arrow functions aren't transpiled into ES5 code.

Then we get the punc error from uglify. Unexpected token: punc (()...

REF: https://github.com/ktquez/vue-disqus/issues/9

ktquez commented 5 years ago

@pxwee5 I will do a refactory on this plugin and fix this. Thanks for the feedback

zangxx66 commented 5 years ago

Me too.I can't post files to my server right now.

zangxx66 commented 5 years ago

I think your js file has some errors,you may need rebuild it ,if I reference vue file it is ok.

ktquez commented 4 years ago

@zangxx66

VueDisqus v4, can you check if the error persist?

ktquez commented 4 years ago

If the problem persists, feel free to reopen that issue.