ktr0731 / evans

Evans: more expressive universal gRPC client
MIT License
4.3k stars 189 forks source link

After exiting evans REPL, the terminal doesn't echo anymore #515

Closed xtofl closed 2 years ago

xtofl commented 2 years ago

Describe the bug

After exiting evans REPL, the terminal doesn't echo anymore.

To reproduce

/tmp/tmp.3pbHjjzpqb$ ls
evans  evans_linux_386.tar.gz  x.proto
/tmp/tmp.3pbHjjzpqb$ cat x.proto 
syntax = "proto3";
message X {
    int32 s = 1;
}
service Bar {
  rpc Foo(X) returns (X);
}
/tmp/tmp.3pbHjjzpqb$ evans repl --proto x.proto --host localhost --port 5000

  ______
 |  ____|
 | |__    __   __   __ _   _ __    ___
 |  __|   \ \ / /  / _. | | '_ \  / __|
 | |____   \ V /  | (_| | | | | | \__ \
 |______|   \_/    \__,_| |_| |_| |___/

 more expressive universal gRPC client

Bar@localhost:5000> exit
Good Bye :)
/tmp/tmp.3pbHjjzpqb$ evans  evans_linux_386.tar.gz  x.proto    <<<< I typed 'ls'

Expected behavior

After exit, what I type is still echoed onto the terminal.

Screenshots

evans-no-echo

Environment

Additional context

ktr0731 commented 2 years ago

Thanks for reporting the issue. This is fixed by https://github.com/ktr0731/evans/pull/528.