search

ktr0731 / evans

Evans: more expressive universal gRPC client
MIT License
4.23k stars 187 forks source link

add support for unix domain sockets #680

Open flokli opened 11 months ago

flokli commented 11 months ago

grpc.NewClient already supports connecting to unix domain sockets, and accepts a string anyways.

As a quick fix, detect the address starting with unix:// and don't add the port.

In the long term, we might want to deprecate host and port cmdline args in favor of a single address arg.

Fixes #654.

codecov[bot] commented 11 months ago

Codecov Report

Merging #680 (55d7e7a) into master (d1bc03a) will increase coverage by 0.02%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #680 +/- ## ========================================== + Coverage 77.10% 77.13% +0.02% ========================================== Files 57 57 Lines 3910 3915 +5 ========================================== + Hits 3015 3020 +5 Misses 647 647 Partials 248 248 ```
flokli commented 10 months ago

@ktr0731 poke ;-)